[
https://issues.apache.org/jira/browse/HBASE-3279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12935965#action_12935965
]
HBase Review Board commented on HBASE-3279:
-------------------------------------------
Message from: "Andrew Purtell" <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1254/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
After HBASE-3275 the REST gateway uses Jetty's GzipFilter to will return gzip
or deflate encoded content to the client if the client requested it using the
appropriate Accept-Encoding header. However Jetty's GzipFilter only wraps
output side processing.
This patch implements a filter that also wraps input side processing, so
clients can submit compressed PUT or POST bodies.
This addresses bug HBASE-3279.
http://issues.apache.org/jira/browse/HBASE-3279
Diffs
-----
src/main/java/org/apache/hadoop/hbase/rest/Main.java 54866b6
src/main/java/org/apache/hadoop/hbase/rest/filter/GZIPRequestStream.java
PRE-CREATION
src/main/java/org/apache/hadoop/hbase/rest/filter/GZIPRequestWrapper.java
PRE-CREATION
src/main/java/org/apache/hadoop/hbase/rest/filter/GZIPResponseStream.java
PRE-CREATION
src/main/java/org/apache/hadoop/hbase/rest/filter/GZIPResponseWrapper.java
PRE-CREATION
src/main/java/org/apache/hadoop/hbase/rest/filter/GzipFilter.java
PRE-CREATION
src/test/java/org/apache/hadoop/hbase/rest/HBaseRESTTestingUtility.java
5e943ec
src/test/java/org/apache/hadoop/hbase/rest/TestGzipFilter.java PRE-CREATION
Diff: http://review.cloudera.org/r/1254/diff
Testing
-------
New unit test, passes.
Thanks,
Andrew
> [rest] Filter for gzip/deflate content encoding that wraps both input and
> output side
> -------------------------------------------------------------------------------------
>
> Key: HBASE-3279
> URL: https://issues.apache.org/jira/browse/HBASE-3279
> Project: HBase
> Issue Type: Improvement
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.20.7, 0.90.0
>
>
> After HBASE-3275 the REST gateway will return gzip or deflate encoded content
> to the client if the client requested it using the appropriate
> Accept-Encoding header. However Jetty's GzipFilter only wraps output side
> processing. A client can submit gzip or deflate encoded requests (i.e.
> Content-Encoding: gzip ; Content-Type: ...) but the data is not decoded, it
> is simply passed through.
> Implement a filter that also wraps input side processing, so clients can
> submit compressed PUT or POST bodies.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
