[
https://issues.apache.org/jira/browse/HBASE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971517#action_12971517
]
HBase Review Board commented on HBASE-3360:
-------------------------------------------
Message from: "Jean-Daniel Cryans" <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1293/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
Patch that removes ReplicationLogCleaner from hbase-default.xml and instead
injects from the Replication class. There's also some cleanup on how HConstants
are used.
This addresses bug HBASE-3360.
http://issues.apache.org/jira/browse/HBASE-3360
Diffs
-----
/trunk/src/main/java/org/apache/hadoop/hbase/HConstants.java 1049375
/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1049375
/trunk/src/main/java/org/apache/hadoop/hbase/master/LogCleaner.java 1049375
/trunk/src/main/java/org/apache/hadoop/hbase/replication/regionserver/Replication.java
1049375
/trunk/src/main/resources/hbase-default.xml 1049375
Diff: http://review.cloudera.org/r/1293/diff
Testing
-------
Thanks,
Jean-Daniel
> ReplicationLogCleaner is enabled by default in 0.90 -- causes NPE
> -----------------------------------------------------------------
>
> Key: HBASE-3360
> URL: https://issues.apache.org/jira/browse/HBASE-3360
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: Jean-Daniel Cryans
> Fix For: 0.90.0
>
>
> {code}
> 2010-12-15 00:33:17,706 ERROR org.apache.hadoop.hbase.master.LogCleaner:
> Caught exception
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.replication.master.ReplicationLogCleaner.isLogDeletable(ReplicationLogCleaner.java:59)
> at
> org.apache.hadoop.hbase.master.LogCleaner.chore(LogCleaner.java:138)
> at org.apache.hadoop.hbase.Chore.run(Chore.java:66)
> at org.apache.hadoop.hbase.master.LogCleaner.run(LogCleaner.java:165)
> {code}
> Assigning J-D at his request.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
