[ 
https://issues.apache.org/jira/browse/HBASE-3388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974374#action_12974374
 ] 

stack commented on HBASE-3388:
------------------------------

Here's patch:

{code}
diff --git 
a/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 
b/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
index ea064f2..2b345fb 100644
--- a/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
+++ b/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
@@ -261,8 +261,13 @@ public class AssignmentManager extends ZooKeeperListener {
   throws KeeperException, IOException {
     RegionTransitionData data = ZKAssign.getData(watcher, encodedRegionName);
     if (data == null) return false;
-    HRegionInfo hri = (regionInfo != null)? regionInfo:
-      MetaReader.getRegion(catalogTracker, data.getRegionName()).getFirst();
+    HRegionInfo hri = regionInfo;
+    if (hri == null) {
+      Pair<HRegionInfo, HServerAddress> p =
+        MetaReader.getRegion(catalogTracker, data.getRegionName());
+      if (p == null) return false;
+      hri = p.getFirst();
+    }
     processRegionsInTransition(data, hri);
     return true;
   }
{code}

> NPE processRegionInTransition(AssignmentManager.java:264) doing 
> rolling-restart.sh
> ----------------------------------------------------------------------------------
>
>                 Key: HBASE-3388
>                 URL: https://issues.apache.org/jira/browse/HBASE-3388
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>             Fix For: 0.90.0
>
>
> Trying to run rolling-restart got this:
> {code}
> 2010-12-22 20:16:48,579 FATAL org.apache.hadoop.hbase.master.HMaster: 
> Unhandled exception. Starting shutdown.
> java.lang.NullPointerException
>     at 
> org.apache.hadoop.hbase.master.AssignmentManager.processRegionInTransition(AssignmentManager.java:264)
>     at 
> org.apache.hadoop.hbase.master.AssignmentManager.processFailover(AssignmentManager.java:223)
>     at 
> org.apache.hadoop.hbase.master.HMaster.finishInitialization(HMaster.java:395)
>     at org.apache.hadoop.hbase.master.HMaster.run(HMaster.java:277)
> 2010-12-22 20:16:48,581 INFO org.apache.hadoop.hbase.master.HMaster: Aborting
> 2010-12-22 20:16:48,581 DEBUG org.apache.hadoop.hbase.master.HMaster: 
> Stopping service threads
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to