[
https://issues.apache.org/jira/browse/HBASE-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12977645#action_12977645
]
Gary Helmling commented on HBASE-3405:
--------------------------------------
@Stack, yes, definitely easy to add. Working up patches for 0.90 and trunk.
> Allow HBaseRpcMetrics to register custom interface methods
> ----------------------------------------------------------
>
> Key: HBASE-3405
> URL: https://issues.apache.org/jira/browse/HBASE-3405
> Project: HBase
> Issue Type: Improvement
> Components: ipc
> Reporter: Gary Helmling
> Priority: Minor
>
> Opened from comments on HBASE-2997. James Kennedy notes:
> {quote}
> HBaseRpcMetrics is now logging a WARN message every time it encounters an
> unregistered RPC method.
> In my case I now get huge log files filled with these warnings because the
> hbase-trx transactional extension of HBase uses a subclass of HRegionServer
> that adds new interface methods.
> It's easy enough to tell log4j to ignore HBaseRpcMetrics output.
> However, it would be nice if the Server/HRegionServer HBaseRpcMetrics
> mechanism was more extensible so I could pass down new interfaces or grab the
> HBaseRpcMetrics object to add interfaces from up top...
> {quote}
> {{HBaseRpcMetrics}} already has a public method {{createMetrics(Class)}} to
> register method counters. We just need a way to expose the metrics class to
> allow the region server subclass to call it -- add a {{getMetrics()}} method
> to {{RpcServer}} and {{HBaseServer}}.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
