[ 
https://issues.apache.org/jira/browse/HBASE-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12977983#action_12977983
 ] 

stack commented on HBASE-3419:
------------------------------

Chatting about this up on IRC, the tickle does not happen if we are skipping 
edits.  Thats wrong.  We should tickle even if we skip edits .

Regards making progressable a Chore, I'd say not exactly.  Progressable is 
about whether or no progress is being made.  We dont' want the tickle to happen 
if we are stuck on HDFS.  Chatting w/ Jon,  the tickle should happen not after 
N edits but after P milliseconds AS LONG AS we're making progress. 

Also, killing regionserver if we fail replay recovered.edits in time is wrong.  
Instead we should fail the region open.

> If re-transition to OPENING during log replay fails, server aborts.  Instead, 
> should just cancel region open.
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-3419
>                 URL: https://issues.apache.org/jira/browse/HBASE-3419
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver, zookeeper
>    Affects Versions: 0.90.0, 0.92.0
>            Reporter: Jonathan Gray
>            Priority: Critical
>             Fix For: 0.90.1, 0.92.0
>
>
> The {{Progressable}} used on region open to tickle the ZK OPENING node to 
> prevent the master from timing out a region open operation will currently 
> abort the RegionServer if this fails for some reason.  However it could be 
> "normal" for an RS to have a region open operation aborted by the master, so 
> should just handle as it does other places by reverting the open.
> We had a cluster trip over some other issue (for some reason, the tickle was 
> not happening in < 30 seconds, so master was timing out every time).  Because 
> of the abort on BadVersion, this eventually led to every single RS aborting 
> itself eventually taking down the cluster.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to