[
https://issues.apache.org/jira/browse/HBASE-3599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002721#comment-13002721
]
Greg Wittel commented on HBASE-3599:
------------------------------------
In addition to the doc changes, I think a helper method might be useful. This
would also be useful in case the expected sorting ever changes. Depending on
the API style you want a few ways might include:
{code}
// (1) Static creator method on Result class that sorts input lists/arrays
Result r = Result.createSorted(unsortedlist);
// (2) Static sort(KeyValue[]/List<KeyValue>) method on KeyValue class
Result r = new Result(KeyValue.sort(mylist...))
{code}
> Result constructor assumes input is already sorted
> --------------------------------------------------
>
> Key: HBASE-3599
> URL: https://issues.apache.org/jira/browse/HBASE-3599
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.0
> Reporter: Greg Wittel
> Priority: Minor
>
> The Result(List<KeyValue>) and Result(KeyValue[]) constructor assume that the
> input is already sorted (HBASE-3073, HBASE-2753). This works for normal use
> cases, but not for hand constructed Result objects (e.g. unit tests).
> I encountered this when upgrading to 0.90 that some unit tests now failed due
> to this. One fix is to add some documentation on the constructors that says
> the input MUST be sorted. The other would be to explicitly sort the items
> (not so desirable).
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira