[ 
https://issues.apache.org/jira/browse/HBASE-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003104#comment-13003104
 ] 

Benoit Sigoure commented on HBASE-3581:
---------------------------------------

Yeah I also like the flag suggestion better.  It's easy to implement both in 
the server and in the client.

> hbase rpc should send size of response
> --------------------------------------
>
>                 Key: HBASE-3581
>                 URL: https://issues.apache.org/jira/browse/HBASE-3581
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: ryan rawson
>            Assignee: ryan rawson
>             Fix For: 0.92.0
>
>         Attachments: HBASE-rpc-response.txt
>
>
> The RPC reply from Server->Client does not include the size of the payload, 
> it is framed like so:
> <i32> callId
> <byte> errorFlag
> <byte[]> data
> The data segment would contain enough info about how big the response is so 
> that it could be decoded by a writable reader.
> This makes it difficult to write buffering clients, who might read the entire 
> 'data' then pass it to a decoder. While less memory efficient, if you want to 
> easily write block read clients (eg: nio) it would be necessary to send the 
> size along so that the client could snarf into a local buf.
> The new proposal is:
> <i32> callId
> <i32> size
> <byte> errorFlag
> <byte[]> data
> the size being sizeof(data) + sizeof(errorFlag).

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to