[ 
https://issues.apache.org/jira/browse/HBASE-3648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13007183#comment-13007183
 ] 

stack commented on HBASE-3648:
------------------------------

Fix this comment on commit (It looks like it describes one of the exception 
only, not the NodeExistsException)

{code}
+      // This exception will pop up if the znode under which we're trying to
+      // create the lock is already deleted by another region server, meaning
+      // that the transfer already occured.
+      if (e instanceof KeeperException.NoNodeException ||
+          e instanceof KeeperException.NodeExistsException) {
{code}

Otherwise, seems fine.  +1

> [replication] failover is sloppy with znodes
> --------------------------------------------
>
>                 Key: HBASE-3648
>                 URL: https://issues.apache.org/jira/browse/HBASE-3648
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.1
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>            Priority: Critical
>             Fix For: 0.90.2
>
>         Attachments: HBASE-3648.patch
>
>
> ReplicationZookeeper is a bit sloppy in how it handles the znodes during 
> failover:
> - when creating the lock, it doesn't cleanly handle the situation where the 
> parent znode might already be deleted.
> - when deleting the znodes after a successful move, it doesn't make sure to 
> delete the lock znode last.
> - after deleting the lock, there's a window where another region server could 
> have already created another lock and deleted the znodes which would abort 
> the first region server (saw it on one cluster).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to