[ 
https://issues.apache.org/jira/browse/HBASE-3652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13007554#comment-13007554
 ] 

stack commented on HBASE-3652:
------------------------------

+1  Todd also found this one in src/test/resources/hbase-site.xml the last day:

{code}
  <property>
    <name>hbase.client.pause</name>
    <value>5000</value>
    <description>General client pause value.  Used mostly as value to wait
    before running a retry of a failed get, region lookup, etc.</description>
  </property>
  <property>
    <name>hbase.client.retries.number</name>
    <value>4</value>
    <description>Maximum retries.  Used as maximum for all retryable
    operations such as fetching of the root region from root region
    server, getting a cell's value, starting a row update, etc.
    Default: 10.
    </description>
  </property>
{code}

Instead we should pause for shorter time but retry more in tests?

Might break some dumb tests that ended up relying on above behaviors?

> Speed up tests that enable/disable
> ----------------------------------
>
>                 Key: HBASE-3652
>                 URL: https://issues.apache.org/jira/browse/HBASE-3652
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.1
>            Reporter: Jean-Daniel Cryans
>             Fix For: 0.92.0
>
>
> While trying TestAdmin in the scope of HBASE-3650, I saw that it takes a lot 
> more time to run than it used to. Upon inspection I see that there's 2 
> hardcoded 1 second sleeps in DisableTableHandler and EnableTableHandler in 
> waitUntilDone (which is almost the same code in both cases too). Setting that 
> down to 50ms dropped the run time in half... and I'm sure there's a few other 
> sleeps that we could get rid of.
> I think that at least those 1sec should be configurable so that we can tune 
> them down in the tests, but I wonder if we need them at all.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to