[ 
https://issues.apache.org/jira/browse/HBASE-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017946#comment-13017946
 ] 

[email protected] commented on HBASE-3750:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/573/
-----------------------------------------------------------

Review request for hbase and Lars George.


Summary
-------

Currently HTablePool.putTable() doesn't call table.flushCommits()
If AutoFlush is disabled for table instance, we should call 
table.flushCommits().

When HTable instance is discarded in putTable(), we should call 
tableFactory.releaseHTableInterface().


This addresses bug HBASE-3750.
    https://issues.apache.org/jira/briwse/HBASE-3750


Diffs
-----

  /src/main/java/org/apache/hadoop/hbase/client/HTablePool.java 1090500 

Diff: https://reviews.apache.org/r/573/diff


Testing
-------

TestHTablePool passes.


Thanks,

Ted



> HTablePool.putTable() should call table.flushCommits()
> ------------------------------------------------------
>
>                 Key: HBASE-3750
>                 URL: https://issues.apache.org/jira/browse/HBASE-3750
>             Project: HBase
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 0.90.1
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 3750.txt
>
>
> Currently HTablePool.putTable() doesn't call table.flushCommits()
> This may turn out to be surprise for users
> When HTable instance is discarded in putTable(), we should call 
> tableFactory.releaseHTableInterface().

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to