[
https://issues.apache.org/jira/browse/HBASE-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018476#comment-13018476
]
[email protected] commented on HBASE-3762:
------------------------------------------------------
bq. On 2011-04-11 18:13:10, Gary Helmling wrote:
bq. > /src/test/java/org/apache/hadoop/hbase/client/TestHTablePool.java, line
68
bq. > <https://reviews.apache.org/r/574/diff/1/?file=15592#file15592line68>
bq. >
bq. > I think you should just use fail() here with a message we got an
unexpected exception.
On second thought, no need to even handle the IOException here. Just let it
escape and fail the test.
- Gary
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/574/#review418
-----------------------------------------------------------
On 2011-04-11 01:45:56, Ted Yu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/574/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-04-11 01:45:56)
bq.
bq.
bq. Review request for hbase and Gary Helmling.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Currently HTableFactory.releaseHTableInterface() wraps IOException in
RuntimeException.
bq. We should let HTableInterfaceFactory.releaseHTableInterface() throw
IOException explicitly.
bq.
bq.
bq. This addresses bug HBASE-3762.
bq. https://issues.apache.org/jira/browse/HBASE-3762
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/main/java/org/apache/hadoop/hbase/avro/AvroServer.java 1090768
bq. /src/main/java/org/apache/hadoop/hbase/client/HTableFactory.java 1090768
bq.
/src/main/java/org/apache/hadoop/hbase/client/HTableInterfaceFactory.java
1090768
bq. /src/main/java/org/apache/hadoop/hbase/client/HTablePool.java 1090768
bq. /src/main/java/org/apache/hadoop/hbase/rest/RowResource.java 1090768
bq. /src/test/java/org/apache/hadoop/hbase/client/TestHTablePool.java
1090768
bq.
bq. Diff: https://reviews.apache.org/r/574/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. TestHTablePool and TestAvroServer pass.
bq.
bq.
bq. Thanks,
bq.
bq. Ted
bq.
bq.
> HTableFactory.releaseHTableInterface() wraps IOException in RuntimeException
> ----------------------------------------------------------------------------
>
> Key: HBASE-3762
> URL: https://issues.apache.org/jira/browse/HBASE-3762
> Project: HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.90.2
> Reporter: Ted Yu
> Assignee: Ted Yu
>
> Currently HTableFactory.releaseHTableInterface() wraps IOException in
> RuntimeException.
> We should let HTableInterfaceFactory.releaseHTableInterface() throw
> IOException explicitly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
