[
https://issues.apache.org/jira/browse/HBASE-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019193#comment-13019193
]
stack commented on HBASE-3609:
------------------------------
Ted:
Why do we pass the emptyRS flag? Didn't we just insert an HServerInfo for the
server with not regions into the assignments Map? Isn't an HSI that has an
empty array of Regions enough of a flag such that you don't need this extra
boolean?
Is this used?
{code}
+ static int regionId = 0;
{code}
The new javadoc helps.
Otherwise patch looks good Ted. It seems to be an ornamentation on what we had
previous; rather than taking regionservers at random, it alternatively takes
the newest and then the oldest off the regionserver -- is that right? (Is that
explained in the patch? I don't think I can see it). You've also added this
enhancement: "Basically I find the new regions and put them on different
underloaded servers. Previously one underloaded server would be filled up
before the next underloaded server is considered." Any chance of your proving
the last enhancement with a unit test?
All the other load balancer tests pass?
Thanks.
> Improve the selection of regions to balance; part 2
> ---------------------------------------------------
>
> Key: HBASE-3609
> URL: https://issues.apache.org/jira/browse/HBASE-3609
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: Ted Yu
> Attachments: 3609-double-alternation.txt, 3609-empty-RS.txt,
> hbase-3609-by-region-age.txt, hbase-3609.txt
>
>
> See 'HBASE-3586 Improve the selection of regions to balance' for discussion
> of algorithms that improve on current random assignment.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
