[ 
https://issues.apache.org/jira/browse/HBASE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13698603#comment-13698603
 ] 

stack commented on HBASE-7840:
------------------------------

What is this comment in ClusterManager.java?

{code}
+  // Not in ClusterManager because it uses 'exec'
{code}

Bit odd this is all hardcoded into the script:

{code}
+      cmd += "export HBASE_REGIONSERVER_OPTS='" +
+          jmx +
+          "-server -XX:ParallelGCThreads=4 -XX:+UseParNewGC -Xmn512m " +
+          "-XX:CMSInitiatingOccupancyFraction=80 -verbose:gc 
-XX:+PrintGCDetails " +
+          "-XX:PrintFLSStatistics=1  -XX:+PrintPromotionFailure " +
+          "-XX:+PrintGCTimeStamps -XX:+PrintGCDateStamps -Xloggc:" +
+          getHBaseHome() + "/logs/gc-" + service + ".log " +
+          "-Xms" + heapSize + "m -Xmx" + heapSize + "m -XX:ErrorFile=" +
+          getHBaseHome() + "/logs/gc-" + service + "-err.log" +
+          "'; ";
{code}

Woah!!!  Rad:

{code}
+    toExec += "sudo /sbin/iptables -A INPUT -i lo -j ACCEPT;";
+    toExec += "sudo /sbin/iptables -A OUTPUT -o lo -j ACCEPT;";
+    toExec += "sudo /sbin/iptables -A INPUT -p tcp -s 0/0 -d " + hostname +
+        " --sport 513:65535 --dport 22 -m state --state NEW,ESTABLISHED -j 
ACCEPT;";
+    toExec += "sudo /sbin/iptables -A OUTPUT -p tcp -s " + hostname +
+        " -d 0/0 --sport 22 --dport 513:65535 -m state --state ESTABLISHED -j 
ACCEPT;";
+    toExec += "sudo /sbin/iptables -P INPUT DROP;";
+    toExec += "sudo /sbin/iptables -P OUTPUT DROP;";
+    toExec += "sudo /sbin/iptables -P FORWARD DROP;";
{code}

I skimmed the patch.  These are some really great tests.  Do they work?  +1 on 
commit if they do (even if above freaks me out -- smile)
                
> Enhance the java it framework to start & stop a distributed hbase & hadoop 
> cluster 
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-7840
>                 URL: https://issues.apache.org/jira/browse/HBASE-7840
>             Project: HBase
>          Issue Type: New Feature
>          Components: test
>    Affects Versions: 0.95.2
>            Reporter: Nicolas Liochon
>            Assignee: Nicolas Liochon
>            Priority: Minor
>             Fix For: 0.95.2
>
>         Attachments: 7840.v1.patch, 7840.v3.patch, 7840.v4.patch
>
>
> Needs are to use a development version of HBase & HDFS 1 & 2.
> Ideally, should be nicely backportable to 0.94 to allow comparisons and 
> regression tests between versions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to