[
https://issues.apache.org/jira/browse/HBASE-8849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13699384#comment-13699384
]
stack commented on HBASE-8849:
------------------------------
You are going to get yourself in to trouble here Ram if you do this:
+ CellEncoder(final OutputStream out, boolean encodeMemstoreTS) {
...giving folks option of encoding mvcc (should be called mvcc not memstorets).
What happens if the flag was set encoding but not on decoding? It'll blow up?
The style should be more MvccCellCodec for the codec that includes mvcc and
another NoMvccCellCodec for the codec that does not. For now I'd say just
under the wraps have CellCodec encode the mvcc.
> CellCodec should write and read the memstoreTS/mvccVersion
> ----------------------------------------------------------
>
> Key: HBASE-8849
> URL: https://issues.apache.org/jira/browse/HBASE-8849
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.95.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Labels: keyvalue
> Fix For: 0.98.0
>
> Attachments: HBASE-8849_1.patch, HBASE-8849_2.patch
>
>
> This JIRA is wrt discussion over in HBASE-8496.
> Cell interface and the corresponding CellCodec provides a new way of
> serializing the Keyvalues.
> Cell interface supports getMvccVersion() and the javadoc says it could be > 0
> if it exists or 0 otherwise.
> But we don't tend to write/read the memstoreTS/mvccVersion in the Cell codec.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
