[
https://issues.apache.org/jira/browse/HBASE-8873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13700581#comment-13700581
]
Hadoop QA commented on HBASE-8873:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12590983/HBase-8873-0.94.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/6221//console
This message is automatically generated.
> minor concurrent issue about filesCompacting
> --------------------------------------------
>
> Key: HBASE-8873
> URL: https://issues.apache.org/jira/browse/HBASE-8873
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.95.1, 0.94.9
> Reporter: Liang Xie
> Assignee: Liang Xie
> Attachments: HBase-8873-0.94.txt
>
>
> i am reading compaction code, seems there's a minor thread-safe issue on
> filesCompacting in both 0.94 and trunk, we guard it with synchronized/lock,
> except needsCompaction() function. and the fix should sth like this:
> synchronized (filesCompacting) {
> ...
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
