[
https://issues.apache.org/jira/browse/HBASE-8892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13701829#comment-13701829
]
Hadoop QA commented on HBASE-8892:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12591179/HBase-8892-0.94.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/6235//console
This message is automatically generated.
> should pick the files as older as possible also while hasReferences
> -------------------------------------------------------------------
>
> Key: HBASE-8892
> URL: https://issues.apache.org/jira/browse/HBASE-8892
> Project: HBase
> Issue Type: Bug
> Components: Compaction
> Affects Versions: 0.94.9
> Reporter: Liang Xie
> Assignee: Liang Xie
> Priority: Minor
> Attachments: HBase-8892-0.94.txt
>
>
> Currently, while hasReferences for compactSelection, and if
> compactSelection.getFilesToCompact() has more than maxFilesToCompact files,
> we clear the files from beginning, it's different with the normal minor
> compaction ratio based policy, which tries to do compactSelection from older
> to newer ones as possible.
> {code}
> } else if (compactSelection.getFilesToCompact().size() >
> this.maxFilesToCompact) {
> // all files included in this compaction, up to max
> int pastMax = compactSelection.getFilesToCompact().size() -
> this.maxFilesToCompact;
> compactSelection.getFilesToCompact().subList(0, pastMax).clear();
> {code}
> It makes the beginning files more difficult to be picked up in future's minor
> compaction stage.
> IMHO, it should be like this:
> {code}
> compactSelection.getFilesToCompact()
> .subList(this.maxFilesToCompact,
> compactSelection.getFilesToCompact().size())
> .clear();
> {code}
> It's not a big issue, since occurs while hasReferences returns true only.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
