[ 
https://issues.apache.org/jira/browse/HBASE-8838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13702533#comment-13702533
 ] 

Enis Soztutar commented on HBASE-8838:
--------------------------------------

You mean FSUtils.WINDOWS? I expect that setting to be useful in main code paths 
as well. That mimics Hadoop's Shell.WINDOWS 
(https://github.com/apache/hadoop-common/blob/87fcb29a161fa906ffec4573eb3c84380a4eb6e2/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java#L274),
 and since FSUtils deals with file system, it looked like a good place to put 
it. 
                
> [WINDOWS] FileLink assumptions are broken under NTFS
> ----------------------------------------------------
>
>                 Key: HBASE-8838
>                 URL: https://issues.apache.org/jira/browse/HBASE-8838
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 0.95.2
>
>         Attachments: hbase-8838_v1.patch
>
>
> FileLink assumes that underlying files can be moved while there are open 
> readers. Windows does not allow the file which has active readers to be moved 
> unless the file is opened in shared mode. JDK6 and 7 open the file in 
> exclusive mode by default, so moving the file while there are readers is not 
> possible. 
> Hadoop-on-windows copies the file, if it cannot perform the rename. This will 
> cause duplication, and the original file not being deleted. 
> This affects the unit test TestFileLink. On local mode over NTFS, reading 
> from snapshot files and replication might cause issues, but I don't think it 
> has any other implications on hbase+hdfs on windows.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to