[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chao Shi updated HBASE-8884:
----------------------------
Attachment: hbase-8884-v6.patch
Thanks for your review. Here are fixes for the review comments.
bq. Please add annotation for stability and audience
Fixed.
bq. RpcScheduler can be extracted out of RpcServer, right ?
Fixed. Extracted RpcScheduler into top-level and make RpcSchedulerContext a
inner class of RpcScheduler.
{quote}
For MetricsHBaseServerWrapperImpl.java:
Can retrieval of callQueue be declared in RpcScheduler so that we don't use the
casting above ?
{quote}
I think a scheduler implementation may have different metrics than others. It
would be nice to let each scheduler implementation exposes whatever metrics it
wants. I'm not familiar with the metrics system, anyone knows a solution?
> Pluggable RpcScheduler
> ----------------------
>
> Key: HBASE-8884
> URL: https://issues.apache.org/jira/browse/HBASE-8884
> Project: HBase
> Issue Type: Improvement
> Components: IPC/RPC
> Reporter: Chao Shi
> Assignee: Chao Shi
> Attachments: hbase-8884.patch, hbase-8884-v2.patch,
> hbase-8884-v3.patch, hbase-8884-v4.patch, hbase-8884-v5.patch,
> hbase-8884-v6.patch
>
>
> Today, the RPC scheduling mechanism is pretty simple: it execute requests in
> isolated thread-pools based on their priority. In the current implementation,
> all normal get/put requests are using the same pool. We'd like to add some
> per-user or per-region level isolation, so that a misbehaved user/region will
> not saturate the thread-pool and cause DoS to others easily. The idea is
> similar to FairScheduler in MR. The current scheduling code is not standalone
> and is mixed with others (Connection#processRequest). The issue is the first
> step to extract it to an interface, so that people are free to write and test
> their own implementations.
> This patch doesn't make it completely pluggable yet, as some parameters are
> pass from constructor. This is because HMaster and HRegionServer both use
> RpcServer and they have different thread-pool size config. Let me know if you
> have a solution to this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
