[ https://issues.apache.org/jira/browse/HBASE-8926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13705374#comment-13705374 ]
Andrew Purtell edited comment on HBASE-8926 at 7/11/13 1:39 AM: ---------------------------------------------------------------- Not a big deal. bq. How are we going to default to CMS then Yes, that is what I am arguing, we don't set up any GC in hbase-env.sh, or HBASE_OPTS. Everybody is going to change this. Every other 'export ...' line in hbase-env.sh is commented out except for HBASE_OPTS. bq. If G1 is used, shouldn't that setting override HBASE_OPTS anyway? One common method for incrementally updating configuration is to do something effectively like: {noformat} echo "HBASE_OPTS=\"\$HBASE_OPTS foo\"" >> /etc/hbase/conf/hbase-env.sh {noformat} It's also trivial to edit hbase-env.sh with sed but since every other setting in the default hbase-env.sh seems to serve a documentary purpose... was (Author: apurtell): Not a big deal. bq. How are we going to default to CMS then Yes, that is what I am arguing, we don't set up any GC in hbase-env.sh, or HBASE_OPTS. Everybody is going to change this. Every other setting in hbase-env.sh is commented except for HBASE_OPTS. bq. If G1 is used, shouldn't that setting override HBASE_OPTS anyway? One common method for incrementally updating configuration is to do something effectively like: {noformat} echo "HBASE_OPTS=\"\$HBASE_OPTS foo\"" >> /etc/hbase/conf/hbase-env.sh {noformat} It's also trivial to edit hbase-env.sh with sed but since every other setting in the default hbase-env.sh seems to serve a documentary purpose... > Do not set default GC options in hbase-env.sh > --------------------------------------------- > > Key: HBASE-8926 > URL: https://issues.apache.org/jira/browse/HBASE-8926 > Project: HBase > Issue Type: Bug > Affects Versions: 0.98.0, 0.95.2, 0.94.10 > Reporter: Andrew Purtell > Assignee: Andrew Purtell > Priority: Trivial > Attachments: 8926.patch > > > Exporting default GC options in HBASE_OPTS from hbase-env.sh by default can > interfere with some deployment scenarios. We probably shouldn't be doing that. > Noticed this when using scripts to set up EC2 test clusters for G1 GC. Having > "-XX:+UseConcMarkSweepGC" on the command line in that case will cause the > JVMs to fail to launch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira