[ 
https://issues.apache.org/jira/browse/HBASE-8845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13705381#comment-13705381
 ] 

Enis Soztutar commented on HBASE-8845:
--------------------------------------

Looks good overall. A couple of comments:
 - I like it that everything is configurable.
 - Can you please put up a main() as well and implement Tool interface (you can 
just copy the bits from other integration tests).
 - From a user's perspective for this test, it is not clear perroundOps and 
perloadRows parameters. Maybe you can extend the javadoc for adding some more 
info on what does the test do at each iteration. 
 - Should we continue inserting data while concurrently splitting merging? 



                
> Add integration test for split and online merge
> -----------------------------------------------
>
>                 Key: HBASE-8845
>                 URL: https://issues.apache.org/jira/browse/HBASE-8845
>             Project: HBase
>          Issue Type: Test
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.95.2
>
>         Attachments: trunk-8845.patch
>
>
> We should add an integration test for online merge to exercise online merging 
> while chaos money kills/restarts region servers, moves regions around.  We 
> need to make sure there is no data loss no matter online merge succeeds/fails.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to