[
https://issues.apache.org/jira/browse/HBASE-8926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13705934#comment-13705934
]
Andrew Purtell commented on HBASE-8926:
---------------------------------------
bq. It almost seems like we need -default and -site kind of thing in
hbase-env.sh.
I have no opinion on that.
It would not help the situation here where there are no 'defaults' except
HBASE_OPTS, which hardcodes a GC strategy that not everyone is going to want
(increasingly).
In addition to the points mentioned above, the assignment of HBASE_OPTS in
hbase-env.sh replaces any existing value of HBASE_OPTS which might be in the
environment, so it's unhelpful on that account too.
> Do not set default GC options in hbase-env.sh
> ---------------------------------------------
>
> Key: HBASE-8926
> URL: https://issues.apache.org/jira/browse/HBASE-8926
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.98.0, 0.95.2, 0.94.10
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Priority: Trivial
> Attachments: 8926.patch
>
>
> Exporting default GC options in HBASE_OPTS from hbase-env.sh by default can
> interfere with some deployment scenarios. We probably shouldn't be doing that.
> Noticed this when using scripts to set up EC2 test clusters for G1 GC. Having
> "-XX:+UseConcMarkSweepGC" on the command line in that case will cause the
> JVMs to fail to launch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
