[
https://issues.apache.org/jira/browse/HBASE-8884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13707871#comment-13707871
]
Ted Yu commented on HBASE-8884:
-------------------------------
Patch v6 looks good. Minor comments below.
For RpcScheduler interface, please add javadoc for the method parameters.
For SimpleRpcScheduler:
{code}
+ * A scheduler that maintains isolated handler pools for high-priority and
replication
+ * requests.
{code}
There are actually 3 queues. Better make the above comment clearer.
RpcServer.CallRunner can be package private.
> Pluggable RpcScheduler
> ----------------------
>
> Key: HBASE-8884
> URL: https://issues.apache.org/jira/browse/HBASE-8884
> Project: HBase
> Issue Type: Improvement
> Components: IPC/RPC
> Reporter: Chao Shi
> Assignee: Chao Shi
> Attachments: hbase-8884.patch, hbase-8884-v2.patch,
> hbase-8884-v3.patch, hbase-8884-v4.patch, hbase-8884-v5.patch,
> hbase-8884-v6.patch
>
>
> Today, the RPC scheduling mechanism is pretty simple: it execute requests in
> isolated thread-pools based on their priority. In the current implementation,
> all normal get/put requests are using the same pool. We'd like to add some
> per-user or per-region level isolation, so that a misbehaved user/region will
> not saturate the thread-pool and cause DoS to others easily. The idea is
> similar to FairScheduler in MR. The current scheduling code is not standalone
> and is mixed with others (Connection#processRequest). The issue is the first
> step to extract it to an interface, so that people are free to write and test
> their own implementations.
> This patch doesn't make it completely pluggable yet, as some parameters are
> pass from constructor. This is because HMaster and HRegionServer both use
> RpcServer and they have different thread-pool size config. Let me know if you
> have a solution to this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
