[
https://issues.apache.org/jira/browse/HBASE-3721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026849#comment-13026849
]
[email protected] commented on HBASE-3721:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/572/#review611
-----------------------------------------------------------
/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
<https://reviews.apache.org/r/572/#comment1255>
Your suggestion is good.
Looking at existing usage of ExecutorService in SplitTransaction and
HConnectionManager, we submit all Callable's and then wait for them to complete.
I will try to use some data structure, such as Map<byte[], Future>, so that
producer and consumer work concurrently.
- Ted
On 2011-04-09 14:00:23, Ted Yu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/572/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-04-09 14:00:23)
bq.
bq.
bq. Review request for hbase and Todd Lipcon.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. I refactored LoadIncrementalHFiles so that tryLoad() queues work items in
List<ServerCallable<Void>>. doBulkLoad() periodically sends batch of
ServerCallable's to HBase cluster.
bq. I added the following method to HConnection/HConnectionManager:
bq. public <T> void getRegionServerWithRetries(ExecutorService pool,
bq. List<ServerCallable<T>> callables, Object[] results)
bq. This method uses thread pool to send multiple ServerCallable's through
getRegionServerWithRetries(ServerCallable<T> callable).
bq.
bq. I introduced two new config parameters: hbase.loadincremental.threads.max
and hbase.loadincremental.batch.size
bq. hbase.loadincremental.batch.size is for configuring the batch size above
which HConnection.getRegionServerWithRetries() would be called. In Adam's case,
there're many small HFiles. LoadIncrementalHFiles shouldn't wait until all
HFiles have been scanned.
bq. hbase.loadincremental.threads.max controls the maximum number of threads
in thread pool.
bq.
bq.
bq. This addresses bug HBASE-3721.
bq. https://issues.apache.org/jira/browse/HBASE-3721
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/main/java/org/apache/hadoop/hbase/client/HConnection.java 1090500
bq. /src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
1090500
bq. /src/main/java/org/apache/hadoop/hbase/client/HTable.java 1090500
bq.
/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
1090500
bq.
bq. Diff: https://reviews.apache.org/r/572/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. TestLoadIncrementalHFiles and TestHFileOutputFormat pass.
bq.
bq.
bq. Thanks,
bq.
bq. Ted
bq.
bq.
> Speedup LoadIncrementalHFiles
> -----------------------------
>
> Key: HBASE-3721
> URL: https://issues.apache.org/jira/browse/HBASE-3721
> Project: HBase
> Issue Type: Improvement
> Components: util
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 3721-v2.txt, 3721-v3.txt, 3721-v4.txt, 3721.txt
>
>
> From Adam Phelps:
> from the logs it looks like <1% of the hfiles we're loading have to be split.
> Looking at the code for LoadIncrementHFiles (hbase v0.90.1), I'm actually
> thinking our problem is that this code loads the hfiles sequentially. Our
> largest table has over 2500 regions and the data being loaded is fairly well
> distributed across them, so there end up being around 2500 HFiles for each
> load period. At 1-2 seconds per HFile that means the loading process is very
> time consuming.
> Currently server.bulkLoadHFile() is a blocking call.
> We can utilize ExecutorService to achieve better parallelism on multi-core
> computer.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
