[ 
https://issues.apache.org/jira/browse/HBASE-7826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13709107#comment-13709107
 ] 

Jean-Daniel Cryans commented on HBASE-7826:
-------------------------------------------

[~shiven] Thank you for uploading the patch for trunk. Please be aware that 
Thrift 0.9.0 is used in that branch, not 0.8.0 which you used. Just to be safe, 
can you regenerate the thrift files with the correct version.

Also, since we are adding a new functionality, could you write a small unit 
test that exercises your new code and add it to {{TestThriftServer}}?
                
> Improve Hbase Thrift v1 to return results in sorted order
> ---------------------------------------------------------
>
>                 Key: HBASE-7826
>                 URL: https://issues.apache.org/jira/browse/HBASE-7826
>             Project: HBase
>          Issue Type: New Feature
>          Components: Thrift
>    Affects Versions: 0.94.0
>            Reporter: Shivendra Pratap Singh
>            Assignee: Shivendra Pratap Singh
>            Priority: Minor
>              Labels: Hbase, Thrift
>         Attachments: hbase_7826.patch, hbase_7826.patch, 
> hbase_7826_sortcolumnFlag.1.patch, hbase_7826_sortcolumnFlag.2.patch, 
> hbase_7826_sortcolumnFlag.3.patch, hbase_7826_sortcolumnFlag.patch, 
> hbase_7826_trunk.patch
>
>
> Hbase natively stores columns sorted based on the column qualifier. A scan is 
> guaranteed to return sorted columns. The Java API works fine but the Thrift 
> API is broken. Hbase uses TreeMap that ensures that sort order is maintained. 
> However Hbase thrift specification uses a simple Map to store the data. A 
> map, since it is unordered doesn't result in columns being returned in a sort 
> order that is consistent with their storage in Hbase.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to