[ 
https://issues.apache.org/jira/browse/HBASE-8966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13710586#comment-13710586
 ] 

Andrew Purtell edited comment on HBASE-8966 at 7/17/13 1:17 AM:
----------------------------------------------------------------

bq. From the doc: Neither DescriptiveStatistics nor SummaryStatistics is 
thread-safe.

Thanks, originally I had synchronized blocks around the updates but removed 
them. Seems the version of the patch I put up is missing that todo, sorry about 
that. 

bq. Last time, I checked DescriptiveStats, I remember being concerned about 
it's performance. 

Yeah, so then I'm going to remove the fix versions and just leave this hanging 
around, because I can see this is going to be more involved than I want to 
invest time in.

Thanks for taking a look. Maybe someday I'll redo this with threadsafe stats.

Edit: Hit save too soon.
                
      was (Author: apurtell):
    bq. From the doc: Neither DescriptiveStatistics nor SummaryStatistics is 
thread-safe.

Thanks, originally I had synchronized blocks around the updates but removed 
them. Seems the version of the patch I put up is missing that todo, sorry about 
that. 

bq. Last time, I checked DescriptiveStats, I remember being concerned about 
it's performance. 

Yeah, so then I'm going to remove the fix versions and just leave this hanging 
around, because I can see this is going to be more involved than I want to 
invest time in.
                  
> Add YCSB-like summary statistics to LoadTestTool
> ------------------------------------------------
>
>                 Key: HBASE-8966
>                 URL: https://issues.apache.org/jira/browse/HBASE-8966
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>            Reporter: Andrew Purtell
>            Priority: Trivial
>         Attachments: 8966-0.94.patch, 8966.patch
>
>
> LoadTestTool does not provide summary statistics after completion. Provide 
> them. Make them similar to YCSB summary output for post parsing convenience.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to