[
https://issues.apache.org/jira/browse/HBASE-8699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13712846#comment-13712846
]
Enis Soztutar commented on HBASE-8699:
--------------------------------------
Latest version looks good to me. We can move the reflection logic inside the
isFileClosed() method with a static variable, but not that big of a reason to
change it if no other changes are needed.
Once we get HBASE-8670, we should backport this to 0.94 as well.
> Parameter to DistributedFileSystem#isFileClosed should be of type Path
> ----------------------------------------------------------------------
>
> Key: HBASE-8699
> URL: https://issues.apache.org/jira/browse/HBASE-8699
> Project: HBase
> Issue Type: Bug
> Components: wal
> Reporter: Ted Yu
> Assignee: Ted Yu
> Fix For: 0.98.0, 0.95.2, 0.94.11
>
> Attachments: 8699-v1.txt, 8699-v3.txt, 8699-v4.txt, 8699-v5.txt,
> 8699-v5.txt
>
>
> Here is current code of FSHDFSUtils#isFileClosed():
> {code}
> boolean isFileClosed(final DistributedFileSystem dfs, final Path p) {
> try {
> Method m = dfs.getClass().getMethod("isFileClosed", new Class<?>[]
> {String.class});
> return (Boolean) m.invoke(dfs, p.toString());
> {code}
> We look for isFileClosed method with parameter type of String.
> However, from
> hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
> (branch-2):
> {code}
> public boolean isFileClosed(Path src) throws IOException {
> {code}
> The parameter type is of Path.
> This means we would get NoSuchMethodException.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
