[ 
https://issues.apache.org/jira/browse/HBASE-8946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hamed Madani updated HBASE-8946:
--------------------------------

    Attachment: HBASE-8946-v4.patch

I uploaded the new patch with modified comment for closeScanner. I was not sure 
how to address your last comment about the test [~larsgeorge]. As I mentioned 
*scanId* is an undefined value with *getScannerResults* function. However, if 
I'm still missing something please let me know before making 0.94 patch
                
> Add a new function to Thrift 2 to open scanner, get results and close scanner
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-8946
>                 URL: https://issues.apache.org/jira/browse/HBASE-8946
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Thrift
>            Reporter: Hamed Madani
>              Labels: thrift2
>         Attachments: HBASE-8946.patch, HBASE-8946-V2.patch, 
> HBASE-8946-V3.patch
>
>
> We found, very often we open a scanner , get x number of rows , then close 
> the scanner immediately. The attached patch , add a new function 
> *getScannerResults* that does just that. 
> Using getScannerResults function reduce number of calls to thrift server. 
> Also since the scanner gets closed immediately, it is less prone to cause 
> memory leak. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to