[ 
https://issues.apache.org/jira/browse/HBASE-8947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13714807#comment-13714807
 ] 

Hamed Madani commented on HBASE-8947:
-------------------------------------

Well I actually had a default value for TDurability, but then I saw if we don't 
set durability, it defaults to CF durability setting. I found it more efficient 
to not set the default on thrift side because client will be sending an extra 
field (default value) when thrift server doesn't need it. (Defaults is set 
without calling setDurability)

So if you agree I can drop writeToWal for trunk patch and depreciate it for 
0.94 ?
                
> Thrift 2 : Replace "bool writeToWAL" with "TDurability durability" 
> -------------------------------------------------------------------
>
>                 Key: HBASE-8947
>                 URL: https://issues.apache.org/jira/browse/HBASE-8947
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Thrift
>            Reporter: Hamed Madani
>            Assignee: Hamed Madani
>         Attachments: HBASE-8947.patch, HBASE-8947-v2.patch
>
>
> Introduce new enum *TDurability* to expose more options for *Write To Wal.* 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to