[
https://issues.apache.org/jira/browse/HBASE-9032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13717775#comment-13717775
]
Aditya Kishore commented on HBASE-9032:
---------------------------------------
bq. Add a log in case of catching IOException ?
These are the instances where Java's checked exceptions add unnecessary
verbosity to the code. The only error/exception that could happen in this clock
is OOM since the IO is to memory buffer. Any attempt to log that would be
pointless. Beside, this class has been LOG less so far so did not want to do
that.
In any case, would do if you insist :)
bq. If you reverse the condition for if statement, you should be able to save
some indentation.
Either that or introduce double return from the function. Was trying to avoid
the later. Further, other functions in this class follow similar style.
> Result.getBytes() returns null if backed by KeyValue array
> ----------------------------------------------------------
>
> Key: HBASE-9032
> URL: https://issues.apache.org/jira/browse/HBASE-9032
> Project: HBase
> Issue Type: Bug
> Components: Client
> Affects Versions: 0.94.9
> Reporter: Aditya Kishore
> Assignee: Aditya Kishore
> Fix For: 0.94.10
>
> Attachments: HBASE-9032.patch
>
>
> This applies only to 0.94 (and earlier) branch.
> If the Result object was constructed using either of Result(KeyValue[]) or
> Result(List<KeyValue>), calling Result.getBytes() returns null instead of the
> serialized ImmutableBytesWritable object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
