[
https://issues.apache.org/jira/browse/HBASE-9059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-9059:
-------------------------
Priority: Major (was: Critical)
> Address HBASE-8764 'Some MasterMonitorCallable should retry' review
> -------------------------------------------------------------------
>
> Key: HBASE-9059
> URL: https://issues.apache.org/jira/browse/HBASE-9059
> Project: HBase
> Issue Type: Bug
> Components: master
> Reporter: stack
> Assignee: stack
> Fix For: 0.95.2
>
>
> Jesse came in w/ some review post-commit. Let me address in this followup.
> Let me paste form our offlist correspondence:
> {quote}
> +++
> b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionOfflineException.java
> @@ -24,7 +24,7 @@ import org.apache.hadoop.hbase.exceptions.RegionException;
>
> /** Thrown when a table can not be located */
> @InterfaceAudience.Public
> [email protected]
> [email protected]
> Really? Same patch? Come on man - you are doing similar cleanup all over the
> place (shakes head)... :)
> [email protected]
> +public class RpcRetryingCaller<T> {
> Calling this stable as the first time its going in seems a bit presumptuous...
> + this.startTime = EnvironmentEdgeManager.currentTimeMillis();
> + int remaining = (int)(callTimeout - (this.startTime -
> this.globalStartTime));
> + if (remaining < MIN_RPC_TIMEOUT) {
> + // If there is no time left, we're trying anyway. It's too late.
> + // 0 means no timeout, and it's not the intent here. So we secure both
> cases by
> + // resetting to the minimum.
> + remaining = MIN_RPC_TIMEOUT;
> + }
> + RpcClient.setRpcTimeout(remaining);
> Looks like some new logic... seems reasonable to me, so I'll let it slide
> this time :)
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
