[
https://issues.apache.org/jira/browse/HBASE-9049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13721845#comment-13721845
]
stack commented on HBASE-9049:
------------------------------
This a bug fix?
{code}
- ScannerCallable s = new ScannerCallable(getConnection(),
- getTableName(), scan, this.scanMetrics);
+ ScannerCallable s = new ScannerCallable(connection, localStartKey, scan,
scanMetrics);
{code}
On your factory, why not lazy instantiation or just create instance on
construction rather than have this 'instantiate' method?
'newCaller' is awkward as method name? 'get'?
Above are nits.
+1. Glad we could help each other out (your patch here improves a bunch on my
mess -- thanks)
> Generalize ServerCallable creation to support custom callables
> --------------------------------------------------------------
>
> Key: HBASE-9049
> URL: https://issues.apache.org/jira/browse/HBASE-9049
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.98.0, 0.95.2, 0.94.11
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Attachments: hbase-9049-trunk-v0.patch, hbase-9049-trunk-v1.patch
>
>
> Currently, sever callables are instantiated via direct calls. Instead, we can
> use a single factory and that allows more specialized callable
> implementations, for instance, using a circuit-breaker pattern (or the
> Hystrix implementation!) to minimize attempts to contact the server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
