[ 
https://issues.apache.org/jira/browse/HBASE-9093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13724541#comment-13724541
 ] 

stack commented on HBASE-9093:
------------------------------

+1

Lets see what hadoopqa says.

In future, rather than:

+    if(getDurability() == Durability.SKIP_WAL) {
+      return false;
+    }
+    return true;

do

return getDurability != Durability.SKIP_WAL;

No biggie.  Thanks for patch Hari.
                
> Hbase client API: Restore the writeToWal method
> -----------------------------------------------
>
>                 Key: HBASE-9093
>                 URL: https://issues.apache.org/jira/browse/HBASE-9093
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.95.0
>            Reporter: Hari Shreedharan
>         Attachments: HBASE-9093.patch
>
>
> The writeToWal is used by downstream projects like Flume to disable writes to 
> WAL to improve performance when durability is not strictly required. But 
> renaming this method to setDurability forces us to use reflection to support 
> hbase versions < 95 - which in turn hits performance, as this method needs to 
> be called on every single write. I recommend adding the old method back as 
> deprecated and removing it once hbase-95/96 becomes the popular version used 
> in prod.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to