[ 
https://issues.apache.org/jira/browse/HBASE-9086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13726154#comment-13726154
 ] 

Lars Hofhansl commented on HBASE-9086:
--------------------------------------

Patch looks good. Some indentation issues, can be fixed upon commit.
Nit:
{code}
+      filter = org.apache.hadoop.hbase.filter.FirstKeyOnlyFilter.new
+      if key_only == 'yes'
+       filter = org.apache.hadoop.hbase.filter.KeyOnlyFilter.new
+      else
{code}

Could move create of the FirstKeyOnlyFilter into the else branch.
                
> Add some options to improve count performance
> ---------------------------------------------
>
>                 Key: HBASE-9086
>                 URL: https://issues.apache.org/jira/browse/HBASE-9086
>             Project: HBase
>          Issue Type: Wish
>          Components: shell
>    Affects Versions: 0.94.2
>            Reporter: Cheney Sun
>         Attachments: HBase-9086.patch
>
>
> The current count command in HBase shell is quite slow if the row size is 
> very big (100+kB each). It would be helpful to provide some option to specify 
> the column to count, which could give user a chance to reduce the data volume 
> to scan. 
> IMHO, only count the row key would be the ideal solution. Not sure how 
> difficult to implement it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to