[
https://issues.apache.org/jira/browse/HBASE-8760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13728951#comment-13728951
]
Jerry He commented on HBASE-8760:
---------------------------------
This is a meaningful change!
Parent region and daughter regions are all included in the snapshot. After
restore/clone, all will be included and brought online?
Code comments:
{code}
snapshtoDisabledRegion(snapshotDir, regionInfo);
{code}
Typo in the method name.
{code}
public void verifyRegions(Path snapshotDir) throws IOException
{code}
==> private void verifyRegions(final Path snapshotDir) throws IOException
{code}
private void verifyRegion(final FileSystem fs, final Path snapshotDir, final
HRegionInfo region)
throws IOException {
// make sure we have region in the snapshot
{code}
That comment line is not indeeded anymore.
> possible loss of data in snapshot taken after region split
> ----------------------------------------------------------
>
> Key: HBASE-8760
> URL: https://issues.apache.org/jira/browse/HBASE-8760
> Project: HBase
> Issue Type: Bug
> Components: snapshots
> Affects Versions: 0.94.8, 0.95.1
> Reporter: Jerry He
> Fix For: 0.98.0, 0.95.2, 0.94.12
>
> Attachments: HBase-8760-0.94.8.patch, HBase-8760-0.94.8-v1.patch,
> HBASE-8760-thz-v0.patch, HBASE-8760-thz-v1.patch
>
>
> Right after a region split but before the daughter regions are compacted, we
> have two daughter regions containing Reference files to the parent hfiles.
> If we take snapshot right at the moment, the snapshot will succeed, but it
> will only contain the daughter Reference files. Since there is no hold on the
> parent hfiles, they will be deleted by the HFile Cleaner after they are no
> longer needed by the daughter regions soon after.
> A minimum we need to do is the keep these parent hfiles from being deleted.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
