[
https://issues.apache.org/jira/browse/HBASE-9108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13731989#comment-13731989
]
Jean-Marc Spaggiari commented on HBASE-9108:
--------------------------------------------
Hum, I'm not able to apply it:
{code}
jmspaggiari@t430s:~/Desktop/hbase-core-trunk$ patch -p0 <
../HBASE-9108.patch._trunk.txt
patching file
hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java
Hunk #1 FAILED at 17.
Hunk #2 FAILED at 102.
Hunk #3 succeeded at 148 (offset 10 lines).
Hunk #4 FAILED at 225.
Hunk #5 succeeded at 280 (offset 15 lines).
Hunk #6 succeeded at 354 (offset 20 lines).
3 out of 6 hunks FAILED -- saving rejects to file
hbase-server/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java.rej
patching file
hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedReader.java
patching file
hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedWriter.java
Hunk #1 succeeded at 22 (offset 2 lines).
Hunk #2 succeeded at 40 (offset 2 lines).
Hunk #3 succeeded at 72 (offset 2 lines).
Hunk #4 succeeded at 92 (offset 2 lines).
Hunk #5 succeeded at 145 (offset 2 lines).
Hunk #6 succeeded at 165 (offset 2 lines).
Hunk #7 succeeded at 185 (offset 2 lines).
Hunk #8 succeeded at 219 (offset 2 lines).
Hunk #9 succeeded at 321 (offset 2 lines).
jmspaggiari@t430s:~/Desktop/hbase-core-trunk$
{code}
You might want to update your trunk code to make sure you have the last version
and re-export the patch...
> LoadTestTool need to have a way to ignore keys which were failed during
> write.
> -------------------------------------------------------------------------------
>
> Key: HBASE-9108
> URL: https://issues.apache.org/jira/browse/HBASE-9108
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.95.0, 0.95.1, 0.94.9, 0.94.10
> Reporter: gautam
> Assignee: gautam
> Priority: Critical
> Attachments: HBASE-9108.patch._trunk.2, HBASE-9108.patch._trunk.3
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> While running the chaosmonkey integration tests, it is found that write
> sometimes fails when the cluster components are restarted/stopped/killed etc..
> The data key which was being put, using the LoadTestTool, is added to the
> failed key set, and at the end of the test, this failed key set is checked
> for any entries to assert failures.
> While doing fail-over testing, it is expected that some of the keys may go
> un-written. The point here is to validate that whatever gets into hbase for
> an unstable cluster really goes in, and hence read should be 100% for
> whatever keys went in successfully.
> Currently LoadTestTool has strict checks to validate every key being written
> or not. In case any keys is not written, it fails.
> I wanted to loosen this constraint by allowing users to pass in a set of
> exceptions they expect when doing put/write operations over hbase. If one of
> these expected exception set is thrown while writing key to hbase, the failed
> key would be ignored, and hence wont even be considered again for subsequent
> write as well as read.
> This can be passed to the load test tool as csv list parameter
> -allowed_write_exceptions, or it can be passed through hbase-site.xml by
> writing a value for "test.ignore.exceptions.during.write"
> Here is the usage:
> -allowed_write_exceptions
> "java.io.EOFException,org.apache.hadoop.hbase.NotServingRegionException,org.apache.hadoop.hbase.client.NoServerForRegionException,org.apache.hadoop.hbase.ipc.ServerNotRunningYetException"
> Hence, by doing this the existing integration tests can also make use of this
> change by passing it as property in hbase-site.xml, as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
