[
https://issues.apache.org/jira/browse/HBASE-8441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13737675#comment-13737675
]
Jean-Daniel Cryans commented on HBASE-8441:
-------------------------------------------
ReplicationException needs more javadoc, maybe explain how they are generated
and what to do with them.
Should KeeperException be pulled in?
bq. + private void connectExistingPeers() throws ReplicationException,
KeeperException {
2 => 3 exceptions?
{quote}
- private ReplicationPeer getPeer(String peerId) throws IOException,
KeeperException {
+ private ReplicationPeer getPeer(String peerId) throws ReplicationException,
IOException,
+ KeeperException {
{quote}
Here you use "Internal Error:", other places you use "Internal Error"
bq. + "Internal Error:
And sometimes it's:
bq. + throw new IOException("Failed replication handler create", e);
The rest of the patch would generate similar comments from me. I think it's
nice we don't throw tons of exceptions and that we make it more consistent, but
there's still more consistency work to be done.
> [replication] Refactor KeeperExceptions thrown from replication state
> interfaces into replication specific exceptions
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-8441
> URL: https://issues.apache.org/jira/browse/HBASE-8441
> Project: HBase
> Issue Type: Improvement
> Reporter: Chris Trezzo
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.95.2
>
> Attachments: HBASE-8441-v1.patch
>
>
> Currently, the replication state interfaces (state, peers and queues) throw
> KeeperExceptions from some of their methods. Refactor these into replication
> specific exceptions to prevent the implementation details of Zookeeper from
> leaking through.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
