[
https://issues.apache.org/jira/browse/HBASE-9164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jonathan Hsieh updated HBASE-9164:
----------------------------------
Attachment: hbase-9164.patch
Attached skecth of trunk version. Will do a port for 0.95 as well.
This patch is mostly brain dead but does one potentially subtle change that
should be examined because of comparators.
The old implementation has KVComparator which has a "raw" KeyComparator which
could be a basic KeyComparator or a MetaKeyComparator. MetaComparator
subclassed KVComparator.
The new implementation 1) does comparisons only using the Cell interface
methods, 2) moves logic for MetaKeyComparator vs RawComparator into
MetaComprator and KVComparator respectively.
There are a few instances of <? extends Cell> remaining in the code, but these
exist primarily in test code. (oh.. need to double check this -- there may be
more than I thought left over).
> Convert List<? extends Cell> anti pattern to List<Cell> pattern.
> ----------------------------------------------------------------
>
> Key: HBASE-9164
> URL: https://issues.apache.org/jira/browse/HBASE-9164
> Project: HBase
> Issue Type: Bug
> Components: Client
> Affects Versions: 0.95.1
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Priority: Blocker
> Fix For: 0.95.2
>
> Attachments: hbase-9164.patch
>
>
> As described in HBASE-9142, using List<? extends Cell> is an anti pattern
> that adds unnecessary typing and casting clutter to the code base. It would
> be best to remove this before we release 0.95.2 or 0.96.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
