[
https://issues.apache.org/jira/browse/HBASE-9203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13740511#comment-13740511
]
Ted Yu commented on HBASE-9203:
-------------------------------
First batch of comments.
{code}
+ public static boolean isIndexTable(String tableName) {
+ return tableName.endsWith(INDEX_TABLE_SUFFIX);
+ }
{code}
What if some existing table(s) at customer site already uses the above suffix ?
How about using metadata in HTableDescriptor for this purpose ?
{code}
+ boolean indexEnabled = this.conf.getBoolean("hbase.use.secondary.index",
false);
{code}
Please introduce constant for the above config.
Looking at changes in BaseMasterObserver.java :
{code}
+ public void preCreateTableHandler(final
ObserverContext<MasterCoprocessorEnvironment> ctx,
+ HTableDescriptor desc, HRegionInfo[] regions) throws IOException {
+ }
{code}
It would be nice if the above changes are extracted from the big patch into a
small one which adds additional hooks to coprocessor API - this way it would be
easier for the small patch to be accepted.
{code}
+ * Copyright 2011 The Apache Software Foundation
{code}
Year is not needed.
For MasterObserverExt.java:
{code}
* This is an extension for the MasterObserver interface. The APIs added into
this interface are not
+ * exposed by HBase. This is internally being used by CMWH HBase. Customer
should not make use of
+ * this interface points. <br>
{code}
Please modify the above comment - it is not consistent with Apache HBase.
> Secondary index support through coprocessors
> --------------------------------------------
>
> Key: HBASE-9203
> URL: https://issues.apache.org/jira/browse/HBASE-9203
> Project: HBase
> Issue Type: New Feature
> Affects Versions: 0.98.0
> Reporter: rajeshbabu
> Assignee: rajeshbabu
>
> We have been working on implementing secondary index in HBase and open
> sourced on hbase 0.94.8 version.
> The project is available on github.
> https://github.com/Huawei-Hadoop/hindex
> This Jira is to support secondary index on trunk(0.98).
> Following features will be supported.
> - multiple indexes on table,
> - multi column index,
> - index based on part of a column value,
> - equals and range condition scans using index, and
> - bulk loading data to indexed table (Indexing done with bulk load)
> Most of the kernel changes needed for secondary index is available in trunk.
> Very minimal changes needed for it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
