[ 
https://issues.apache.org/jira/browse/HBASE-9239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13741864#comment-13741864
 ] 

ramkrishna.s.vasudevan commented on HBASE-9239:
-----------------------------------------------

@Ted
Patch is good.  
I have a suggestion, from the logs could see that the NameSpaceJanitor issues a 
scan on the Meta and that includes Namespace into the blockcache summary.
>From code am not getting where the scan is happening through NameSpaceJanitor. 
> 
May be instead working with the index, we can just check if the testTable and 
testTable2 are available in the list that we are checking.  
If the catalog janitor adds any other namespace entries this may fail?  So we 
will check if the list contains those two tables then it may be easier.
                
> TestStoreFileBlockCacheSummary#testBlockCacheSummary occasionally fails
> -----------------------------------------------------------------------
>
>                 Key: HBASE-9239
>                 URL: https://issues.apache.org/jira/browse/HBASE-9239
>             Project: HBase
>          Issue Type: Test
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 0.98.0
>
>         Attachments: 9239-v1.txt
>
>
> From 
> https://builds.apache.org/job/HBase-0.95/455/testReport/org.apache.hadoop.hbase.regionserver/TestStoreFileBlockCacheSummary/testBlockCacheSummary/
>  :
> {code}
> java.lang.AssertionError: blockCache summary has entries expected:<2> but 
> was:<3>
>       at org.junit.Assert.fail(Assert.java:88)
>       at org.junit.Assert.failNotEquals(Assert.java:743)
>       at org.junit.Assert.assertEquals(Assert.java:118)
>       at org.junit.Assert.assertEquals(Assert.java:555)
>       at 
> org.apache.hadoop.hbase.regionserver.TestStoreFileBlockCacheSummary.testBlockCacheSummary(TestStoreFileBlockCacheSummary.java:112)
> {code}
> This was due to an additional entry for namespace table:
> {code}
> 2013-08-16 00:24:25,337 INFO  [pool-1-thread-1] 
> regionserver.TestStoreFileBlockCacheSummary(110): blockCacheSummary: 
> [BlockCacheSummaryEntry [table=namespace, columnFamily=info, blocks=1, 
> heapSize=512], BlockCacheSummaryEntry [table=testTable, 
> columnFamily=testFamily, blocks=1, heapSize=664], BlockCacheSummaryEntry 
> [table=testTable2, columnFamily=testFamily, blocks=1, heapSize=664]]
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to