[
https://issues.apache.org/jira/browse/HBASE-9262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13744059#comment-13744059
]
stack commented on HBASE-9262:
------------------------------
+ final private static int len(byte[] b) {
+ return b == null ? 0 : b.length;
Do you want to check if an offset in the above?
Does this belong elsewhere? calcIndexKey? In KVUtil?
+1
Can fix above if you want on commit
> Make KeyValue.KEY_COMPARATOR default for HFile WriterFactory
> ------------------------------------------------------------
>
> Key: HBASE-9262
> URL: https://issues.apache.org/jira/browse/HBASE-9262
> Project: HBase
> Issue Type: Sub-task
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-9262.patch
>
>
> This takes completed work mentioned in HBASE-9247 as a reasonably sized patch
> to build upon.
> * Fixed defaults in HFile.Writer factory to default to Key-format-aware
> comparator (KeyComparator, later converted to KVComparator) instead of a
> Key-format oblivious byte[] comparator. (Essentially all instances require
> specifying KEY_COMPARATOR – why not just make it the default).
> ** Found that TestSeekTo, TestReseekTo and a handful of others depend on a
> different comparator because – HBASE-7845 "breaks" assumptions in these tests.
> * Moved getComparator into TableName. (removed an instanceof bad smell)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
