[
https://issues.apache.org/jira/browse/HBASE-8760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13744268#comment-13744268
]
Ted Yu commented on HBASE-8760:
-------------------------------
lgtm
Some comments:
{code}
+ // TODO-REMOVE-ME: HConnectionManager.isTableAvailable() is checking
the SERVER_QUALIFIER
+ // also on offline regions, so to keep the compatibility with older
clients we must add
+ // a location to this region even if it will never be assigned.
{code}
When would the above be removed ?
In restoreReferenceFile():
{code}
+ synchronized (parentsMap) {
+ Pair<String, String> daughters = parentsMap.get(clonedRegionName);
{code}
I don't see synchronized (parentsMap) in other part of the patch.
{code}
+ * Add the specified set of regions to the META table.
+ */
@Override
+ protected void addRegionsToMeta(final CatalogTracker ct, final
List<HRegionInfo> regionInfos)
+ throws IOException {
+ super.addRegionsToMeta(ct, regionInfos);
{code}
The javadoc above @Override seems to be redundant.
> possible loss of data in snapshot taken after region split
> ----------------------------------------------------------
>
> Key: HBASE-8760
> URL: https://issues.apache.org/jira/browse/HBASE-8760
> Project: HBase
> Issue Type: Bug
> Components: snapshots
> Affects Versions: 0.94.8, 0.95.1
> Reporter: Jerry He
> Assignee: Matteo Bertozzi
> Fix For: 0.98.0, 0.94.12, 0.96.0
>
> Attachments: HBase-8760-0.94.8.patch, HBase-8760-0.94.8-v1.patch,
> HBASE-8760-0.94-v4.patch, HBASE-8760-0.94-v5.patch, HBASE-8760-0.94-v6.patch,
> HBASE-8760-0.94-v7.patch, HBASE-8760-0.94-v8-addendum.patch,
> HBASE-8760-0.94-v8.patch, HBASE-8760-thz-v0.patch, HBASE-8760-trunk-v8.patch,
> HBASE-8760-v4.patch, v4-patch-testing-0.94.zip, v4-patch-testing-0.95.2.zip
>
>
> Right after a region split but before the daughter regions are compacted, we
> have two daughter regions containing Reference files to the parent hfiles.
> If we take snapshot right at the moment, the snapshot will succeed, but it
> will only contain the daughter Reference files. Since there is no hold on the
> parent hfiles, they will be deleted by the HFile Cleaner after they are no
> longer needed by the daughter regions soon after.
> A minimum we need to do is the keep these parent hfiles from being deleted.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
