[ 
https://issues.apache.org/jira/browse/HBASE-9300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13747805#comment-13747805
 ] 

stack commented on HBASE-9300:
------------------------------

[~echarles] Your patch justs fixes up the h3 profile, right?  I do not see any 
'trick' going on in your HBASE-6581-20130821.patch ?  Putting the sync 
Interface back in the compatibility module is the way to go for sure.  Is that 
in the multi-megabyte patch on hbase-6581 (I looked at the one before and did 
not see it)


                
> Deal with Hadoop Syncable.sync() removal
> ----------------------------------------
>
>                 Key: HBASE-9300
>                 URL: https://issues.apache.org/jira/browse/HBASE-9300
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Eric Charles
>
> HADOOP-8124 has removed Syncable.sync() in favor of Syncable.hsync().
> Our ProtobufLogWriter calls sync(), which breaks the build when building with 
> Hadoop 3.0.0-SNAPSHOT.
> HBASE-6581 proposes to use reflection in the compat modules to call the 
> correct method (sync for hadoop1* and hadoop2* profiles, hsync for hadoop3 
> profiles).
> This JIRA is here to validate this approach.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to