[ 
https://issues.apache.org/jira/browse/HBASE-9116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Devaraj Das updated HBASE-9116:
-------------------------------

    Attachment: 9116-5.txt

Sorry for the delay in responding. I couldn't get to it until now. Attached 
patch takes care of the comments.

bq. Why updateFavoredNodes takes an OpenRegionRequest?
That's because the argument serves all the purpose of what is needed in the 
updateFavoredNodes RPC. I am open to defining a new argument if you think 
that'd be better.

bq. Is the hbase-site.xml change intentional?
Nope. Accidental..

bq. Can we create a similar putsToMetaTable method which takes a conf in 
MetaEditor? We need to handle exceptions and close the table at the end.
Done (added close)

bq. Perhaps, it is better to log the stack trace as well

Done.

bq. Some function may not throw exception declared

Fixed.

bq. Good stuff. Is this still WIP? How can we use this? Edit the meta table 
from hbase shell?

This is mostly complete. It needs more real life testing. The 
RegionPlacementMaintainer in the patch has the commands to update meta (can be 
run like a regular Java app). That's the tool added (which is the majority of 
the code in this patch).

                
> Add a view/edit tool for favored node mappings for regions
> ----------------------------------------------------------
>
>                 Key: HBASE-9116
>                 URL: https://issues.apache.org/jira/browse/HBASE-9116
>             Project: HBase
>          Issue Type: Improvement
>          Components: Region Assignment
>    Affects Versions: 0.95.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.96.0
>
>         Attachments: 9116-1.txt, 9116-2.txt, 9116-2.txt, 9116-2.txt, 
> 9116-3.txt, 9116-4.txt, 9116-5.txt
>
>
> Add a tool that one can run offline to view the favored node mappings for 
> regions, and also fix the mappings if needed. Such a tool exists in the 
> 0.89-fb branch. Will port it over to trunk/0.95.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to