[
https://issues.apache.org/jira/browse/HBASE-9283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13751607#comment-13751607
]
Hadoop QA commented on HBASE-9283:
----------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12600084/0001-HBASE-9283-Struct-trailing-null-handling.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 8 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/6935//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6935//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6935//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6935//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6935//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6935//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6935//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6935//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6935//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/6935//console
This message is automatically generated.
> Struct and StructIterator should properly handle trailing nulls
> ---------------------------------------------------------------
>
> Key: HBASE-9283
> URL: https://issues.apache.org/jira/browse/HBASE-9283
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.95.2
> Reporter: Nick Dimiduk
> Assignee: Nick Dimiduk
> Fix For: 0.98.0, 0.96.0
>
> Attachments: 0001-HBASE-9283-Struct-trailing-null-handling.patch,
> 0001-HBASE-9283-Struct-trailing-null-handling.patch,
> 0001-HBASE-9283-Struct-trailing-null-handling.patch
>
>
> For a composite row key, Phoenix strips off trailing null columns values in
> the row key. The reason this is important is that then new nullable row key
> columns can be added to a schema without requiring any data upgrade to
> existing rows. Otherwise, adding new row key columns to the end of a schema
> becomes extremely cumbersome, as you'd need to delete all existing rows and
> add them back with a row key that includes a null value.
> Rather than Phoenix needing to modify the iteration code everywhere (as
> [~ndimiduk] outlined here:
> https://issues.apache.org/jira/browse/HBASE-8693?focusedCommentId=13744499&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13744499),
> it'd be better if StructIterator handled this out-of-the-box. Otherwise, if
> Phoenix has to specialize this, we'd lose the interop piece which is the
> justification for switching our type system to this new one in the first
> place.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
