[
https://issues.apache.org/jira/browse/HBASE-9244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757702#comment-13757702
]
ramkrishna.s.vasudevan commented on HBASE-9244:
-----------------------------------------------
Looks good. Just one comment.
The post hook is really needed?
{code}
+ if (this.coprocessorHost != null) {
+ reader = this.coprocessorHost.postStoreFileReaderOpen(fs,
this.getPath(), in, length,
+ cacheConf, dataBlockEncoding, reference, reader);
+ }
{code}
Because if pre hook gives a reader, the post hook will again be called. So we
need to give two impl both doing same.
May be post would be ideal in case where we have a set of steps completed and
do a suitable action based on that. Only for this hook we can have only pre?
Rest looks good.
> Add CP hooks around StoreFileReader creation
> --------------------------------------------
>
> Key: HBASE-9244
> URL: https://issues.apache.org/jira/browse/HBASE-9244
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.98.0
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Attachments: HBASE-9244.patch, HBASE-9244_V2.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
