[ 
https://issues.apache.org/jira/browse/HBASE-9364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13763415#comment-13763415
 ] 

Nick Dimiduk commented on HBASE-9364:
-------------------------------------

{noformat}
-          if (split.length == 2 && split[1].length != 0) {
-            get.addColumn(split[0], split[1]);
+          if (split.length == 2) {
+            if (split[1].length != 0) {
+              get.addColumn(split[0], split[1]);
+            } else {
+              get.addColumn(split[0], HConstants.EMPTY_BYTE_ARRAY);
+            }
{noformat}

No need for the special logic around {{split[1].length != 0}}. If it's length 
== 0, it is an empty byte[].

{noformat}
-          if (!s.contains(":")) {
-            this.columns.add(Bytes.toBytes(s + ":"));
-          } else {
{noformat}

Why do you remove the ':' from the rowspec?

{noformat}
+               sb.append(Bytes.toStringBinary((byte[])e.getKey()));
+               sb.append(':');
{noformat}

ws: no tabs please.

{noformat}
-    result = remoteTable.get(get);    
+    result = remoteTable.get(get);
{noformat}

ws: thanks for cleaning these up.

{noformat}
+    define_test "parse_column_name should  return empty qualifier for 
family-only column specifiers" do
{noformat}

ws: extra space between "should" and "return".
                
> Get request with multiple columns returns partial results
> ---------------------------------------------------------
>
>                 Key: HBASE-9364
>                 URL: https://issues.apache.org/jira/browse/HBASE-9364
>             Project: HBase
>          Issue Type: Bug
>          Components: REST
>    Affects Versions: 0.94.11
>            Reporter: Vandana Ayyalasomayajula
>            Assignee: Vandana Ayyalasomayajula
>            Priority: Minor
>         Attachments: HBASE-9364.00.patch, HBASE-9364.01.patch, 
> hbase-9364_trunk.00.patch, HBASE-9364_trunk.01.patch
>
>
> When a GET request is issue for a table row with multiple columns and columns 
> have empty qualifier like f1: ,  results for empty qualifiers is being 
> ignored. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to