[
https://issues.apache.org/jira/browse/HBASE-9494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13763555#comment-13763555
]
Dan Burkert commented on HBASE-9494:
------------------------------------
[~stack], I can certainly do that. Alternatively, I can change the name of the
rpc back to what it was originally and rename the request and response message
names to match. For example:
MasterAdminProtos.RunCatalogScan will use RunCatalogScan[Request, Response]
instead of CatalogScan[Request, Response]
MasterAdminProtos.Snapshot will use Snapshot[Request, Response] instead of
TakeSnapshot[Request, Response]
etc.
Let me know which you prefer.
> Cleanup inconsistencies in protobuf message and rpc names
> ---------------------------------------------------------
>
> Key: HBASE-9494
> URL: https://issues.apache.org/jira/browse/HBASE-9494
> Project: HBase
> Issue Type: Improvement
> Components: IPC/RPC, Protobufs
> Affects Versions: 0.96.0
> Reporter: Dan Burkert
> Priority: Minor
> Attachments: HBASE-9494.patch
>
>
> This is a minor cleanup of some inconsistencies in names of protobuf messages
> and rpcs. I ran into these while dynamically working with hbase-protocol,
> where it is nice to have message and rpc names as consistent as possible.
> Specifically, most of these changes are to have the rpc name match the
> message names plus [Request, Response]. Changes:
> Message renames:
> AccessControlProtos.UserPermissions[Request, Response] ->
> GetUserPermissions[Request, Response]
> AggregateProtos.AggregateArgument -> AggregateRequest
> AuthenticationProtos.Token[Request, Response] ->
> GetAuthenticationToken[Request, Response]
> AuthenticationProtos.Token[Request, Response] ->
> GetAuthenticationToken[Request, Response]
> MultiRowMutation.MultiMutate[Request, Response] -> MutateRows[Request,
> Response]
> RowProcessorProtos.RowProcessor[Request, Response] ->
> ProcessRowRequest[Request, Response]
> SecureBulkLoadProtos.DelegationTokenProto -> DelegationToken
> RPC renames:
> MasterAdminProtos.RunCatalogScan -> CatalogScan
> MasterAdminProtos.Snapshot -> TakeSnapshot
> MasterAdminProtos.GetCompletedSnapshots -> ListCompletedSnapshots
> RowProcessorProtos.Process -> RowProcessorProtos.ProcessRow
> Outer classname changes:
> MultiRowMutation -> MultiRowMutationProtos
> Tracing -> TracingProtos
> File renames:
> hbase.proto -> HBase.proto
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
