[
https://issues.apache.org/jira/browse/HBASE-9467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13766433#comment-13766433
]
Nicolas Liochon commented on HBASE-9467:
----------------------------------------
I like the patch. And I like code removal.
As stack for the return.
I would propose to reuse RegionTooBusyException. It's seems too similar to
RegionOverloadedException. Or at least one should extend the other.
{code}
+ try {
+ Thread.sleep(pause);
+ } catch (InterruptedException ie) {
+ }
{code}
You can use Threads.sleep (with an 's'), it will handle InterruptedException.
It's in the tests, but the less we shallow interruptedException the better.
+1 with the modifications above, very nice one.
> write can be totally blocked temporarily by a write-heavy region
> ----------------------------------------------------------------
>
> Key: HBASE-9467
> URL: https://issues.apache.org/jira/browse/HBASE-9467
> Project: HBase
> Issue Type: Improvement
> Reporter: Feng Honghua
> Assignee: Feng Honghua
> Attachments: HBASE-9467-trunk-v0.patch
>
>
> Write to a region can be blocked temporarily if the memstore of that region
> reaches the threshold(hbase.hregion.memstore.block.multiplier *
> hbase.hregion.flush.size) until the memstore of that region is flushed.
> For a write-heavy region, if its write requests saturates all the handler
> threads of that RS when write blocking for that region occurs, requests of
> other regions/tables to that RS also can't be served due to no available
> handler threads...until the pending writes of that write-heavy region are
> served after the flush is done. Hence during this time period, from the RS
> perspective it can't serve any request from any table/region just due to a
> single write-heavy region.
> This sounds not very reasonable, right? Maybe write requests from a region
> can only be served by a sub-set of the handler threads, and then write
> blocking of any single region can't lead to the scenario mentioned above?
> Comment?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
