[
https://issues.apache.org/jira/browse/HBASE-9539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13768559#comment-13768559
]
stack commented on HBASE-9539:
------------------------------
Would suggest better names for the constants in DOT_ARCHIVE and DOT_TMP
otherwise folks will ask why you are not using what is in HConstants. Call it
PRE_NS_DOT_ARCHIVE or something like that?
Some more comments on what is going on -- that you are doctoring the return
from HFileLink so that refers to pre_ns locations -- would help.
This is intended?
- if (upgrade) {
+ else if (upgrade) {
Does this make it so this tool only works against pre-0.96 snapshot layout?
(That is probably ok since they should be gone for 0.96).
Nice test.
Yeah, hadoopqa is crazy these times... not you.
> Handle post namespace snapshot files when checking for HFile V1
> -----------------------------------------------------------------
>
> Key: HBASE-9539
> URL: https://issues.apache.org/jira/browse/HBASE-9539
> Project: HBase
> Issue Type: Bug
> Components: migration
> Affects Versions: 0.95.2
> Reporter: Himanshu Vashishtha
> Fix For: 0.98.0, 0.96.0
>
> Attachments: HBase-9539.patch
>
>
> When checking for HFileV1 before upgrading to 96, the snapshot file links
> tries to read from post-namespace locations. The migration script needs to be
> run on 94 cluster, and it requires reading the old (94) layout to check for
> HFileV1.
> {code}
> Got exception while reading trailer for file:
> hdfs://xxx:41020/cops/cluster_collection_events_snapshot/2086db948c484be62dcd76c170fe0b17/meta/cluster_collection_event=42037b88dbc34abff6cbfbb1fde2c900-c24b358ddd2f4429a7287258142841a2
> java.io.FileNotFoundException: Unable to open link:
> org.apache.hadoop.hbase.io.HFileLink
> locations=[hdfs://xxx:41020/hbase-96/data/default/cluster_collection_event/42037b88dbc34abff6cbfbb1fde2c900/meta/c24b358ddd2f4429a7287258142841a2,
>
> hdfs://xxx:41020/hbase-96/.tmp/data/default/cluster_collection_event/42037b88dbc34abff6cbfbb1fde2c900/meta/c24b358ddd2f4429a7287258142841a2,
>
> hdfs://xxx:41020/hbase-96/archive/data/default/cluster_collection_event/42037b88dbc34abff6cbfbb1fde2c900/meta/c24b358ddd2f4429a7287258142841a2]
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
