[
https://issues.apache.org/jira/browse/HBASE-9514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13769237#comment-13769237
]
Enis Soztutar commented on HBASE-9514:
--------------------------------------
A couple of comments:
- should we rename AM.acquireLock -> AM.acquireRegionLock()
- Why not do this for meta?
{code}
+ if (!region.isMetaRegion() &&
+ regionStates.wasRegionOnDeadServer(encodedName)) {
{code}
Is it safe to expire a server like this. It means the master cannot connect to
it, but it may still have the zk lease.
{code}
+ } else {
+ LOG.info(server + " is not reachable, expire it");
+ serverManager.expireServer(server);
+ }
{code}
- Should we rename RegionStates.logSplit() -> markAssignable() or something
like it.
Is this timeout intended to be active?
{code}
+ @Test //(timeout=60000)
{code}
> Prevent region from assigning before log splitting is done
> ----------------------------------------------------------
>
> Key: HBASE-9514
> URL: https://issues.apache.org/jira/browse/HBASE-9514
> Project: HBase
> Issue Type: Bug
> Components: Region Assignment
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Blocker
> Attachments: trunk-9514_v1.patch
>
>
> If a region is assigned before log splitting is done by the server shutdown
> handler, the edits belonging to this region in the hlogs of the dead server
> will be lost.
> Generally this is not an issue if users don't assign/unassign a region from
> hbase shell or via hbase admin. These commands are marked for experts only in
> the hbase shell help too. However, chaos monkey doesn't care.
> If we can prevent from assigning such regions in a bad time, it would make
> things a little safer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
